Add restart device and software update commands to Devices panel#829
Merged
chrisdp merged 21 commits intoJun 25, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add restart device and software update callbacks to device view panel
Add device restart and software update controls to Device View Panel
Jun 23, 2026
Copilot
AI
changed the title
Add device restart and software update controls to Device View Panel
Move device restart and software update actions to DevicesViewProvider
Jun 23, 2026
Copilot
AI
changed the title
Move device restart and software update actions to DevicesViewProvider
Remove accidental RTA/RDB view changes from device restart feature
Jun 23, 2026
Copilot
AI
changed the title
Remove accidental RTA/RDB view changes from device restart feature
Add restart device and software update commands to Devices panel
Jun 23, 2026
chrisdp
previously requested changes
Jun 23, 2026
- Remove leftover rokuDeviceView command entries from VscodeCommand.ts - Move restartDevice and checkForUpdates from DevicesViewProvider to BrightScriptCommands - Commands now accept optional host parameter instead of DeviceTreeItem - Commands look up password via credentialStore using device serial number - Commands display device picker if no host provided - Update tree item arguments to pass device key for lookup - Remove corresponding tests from DevicesViewProvider.spec.ts
Add explicit device existence checks in command handlers before calling restartDevice and checkForUpdates to provide clear error messages when device is not found, instead of falling back to device picker.
Restart Device and Check for Software Updates now resolve the developer password from all known sources and validate each against the device, prompting and re-prompting on rejection, the same way a debug launch does. They previously read only the credential store, leaving the password undefined and causing auth failures. - Always prompt for the target device via the picker when invoked without one - Remove the redundant Devices view context-menu entries; the commands remain as tree items and in the command palette - Add unit tests
TwitchBronBron
requested changes
Jun 24, 2026
Wrap the reboot and update requests in an indeterminate progress notification while they're in flight, and report success with a timed notification that auto-dismisses.
Move candidate collection, the validation loop, the prompt, and credential-store persistence into UserInputManager.resolveDevicePassword. The debug configuration provider and the restart/update commands both delegate to it, passing their own extra candidate passwords. The provider keeps its legacy-password migration and sets the remotePassword fallback itself.
TwitchBronBron
approved these changes
Jun 25, 2026
Use a concise title + detail modal for the restart and update confirmations, and drop the success notification now that the in-progress indicator covers that feedback.
chrisdp
marked this pull request as ready for review
June 25, 2026 15:50
chrisdp
enabled auto-merge (squash)
June 25, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Restart Device and Check for Software Updates actions to the Devices panel.
Both actions are available as items under each device and from the command palette. They are only offered for devices running Roku OS 15.0.4 or later, which is required for the reboot and update endpoints.
Each action confirms before contacting the device. The target is the device whose item was clicked, or, when run from the command palette, the device chosen from the picker. The developer password is resolved and validated against the device the same way a debug launch is: stored, configured, and default passwords are tried in order, and the user is prompted (and re-prompted on rejection) when none are accepted.
Example
Expanding a device in the Devices panel (Roku OS 15.0.4+):